Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMA instruction support #1

Open
dmikushin opened this issue Jun 16, 2023 · 1 comment
Open

MMA instruction support #1

dmikushin opened this issue Jun 16, 2023 · 1 comment

Comments

@dmikushin
Copy link

Hi, thanks for working on this! 👍

I could not find mma instruction support in the codebase. Maybe my search is too quick, I'm simply grepping for grep mma * -R -i.

Is mma really missing, if yes - do you plan to add it? A README note about feature completion table would be really helpful!

@ariasanovsky
Copy link
Owner

Hi @dmikushin thanks for checking out this project! I believe mma is captured as an Operation:

#[derive(Debug, PartialEq)]
pub(crate) struct Operation<'a> {
    operation: &'a str,
    arguments: &'a str,
}

Could you share a sample ptx file which has mma in it so we can see how it is currently handled? Feel free to include it in src/ptx_files/ as a commit, or share it here in a comment.

Nvidia has reserved 132 instruction keywords, including mma. I made one attempt to rework the operation field with a fat enum and a lot of hard-coding. Perhaps this is an avenue for future consideration.

Here is the output parse_body_example.txt of cargo test parse_body_example -- --nocapture.

I made ptx-parser in service of another WIP crate ptx-viz. Features will trickle in as I need them for viz. Feel free to suggest others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants