-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checks fail for classes with immutable metaclasses #65
Labels
enhancement
New feature or request
Comments
7 tasks
ariebovenberg
added a commit
that referenced
this issue
Feb 26, 2022
8 tasks
ariebovenberg
added a commit
that referenced
this issue
Feb 26, 2022
ariebovenberg
added a commit
that referenced
this issue
Feb 26, 2022
Awesome, thank you for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
First of all, thank you for this neat tool!
I've been seeing issues with checking classes that have immutable metaclasses, or generally metaclasses that raise an exception in their
__setattr__
(or__delattr__
), due to this:slotscheck/src/slotscheck/checks.py
Line 74 in 9a2cba3
This seems to be the case defined in the tests here:
slotscheck/tests/src/test_checks.py
Lines 41 to 47 in 9a2cba3
I'm not too familiar with the specifics of Python extensions, so I couldn't come up with any good solutions, but it would be nice if these types were supported as well.
edit: the second half of this answer may be useful? Seems like an implementation quirk though, so it would need some testing to make sure it's reliable :/
The text was updated successfully, but these errors were encountered: