feat(anta.tests): Add support for IPv6 for VerifyReachability test #1019
+75
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitthalmagadum
requested review from
carl-baillargeon,
gmuloc and
geetanjalimanegslab
CodSpeed Performance ReportMerging #1019 will not alter performanceComparing Summary
|
vitthalmagadum
changed the title
gmuloc
reviewed
Jan 28, 2025
Comment on lines
+40
to
+41
| - source: fd12:3456:789a:1::1 | ||
| destination: fd12:3456:789a:1::2 |
There was a problem hiding this comment.
try out using one ipv4/one ipv6 for sourfce/dest and see the result - in theory it should not work and we can block these scenarios with a validator
There was a problem hiding this comment.
checked on device during call -> block it with validator
There was a problem hiding this comment.
use EOS error message IP address family for desintation does not match source
There was a problem hiding this comment.
The framework handles command errors. Do we still need to add a validator?
|
gmuloc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix VerifyReachability test as does not accept IPv6 input in YAML
Fixes #921
Checklist:
pre-commit run)tox -e testenv)