Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are only standard-typed ACLs valid? #40

Open
ajmyyra opened this issue Jul 2, 2020 · 1 comment
Open

Are only standard-typed ACLs valid? #40

ajmyyra opened this issue Jul 2, 2020 · 1 comment

Comments

@ajmyyra
Copy link

ajmyyra commented Jul 2, 2020

Hi there,

I noticed that ACL functions under module/acl.go only returns standard-typed ACLs. One such example can be seen in https://github.com/aristanetworks/goeapi/blob/master/module/acl.go#L161 . Device configs aren't often like this and many can have extended ACLs without any specified type, i.e. ip access-list NAME instead of ip access-list standard NAME, or ip access-list payload NAME.

Is the goeapi code just lacking support for non-standard ACL types (and if this is the case, would you be interested in PR to fix this?), or are general-typed ACLs the only thing you'll consider to be valid?

@cheynearista
Copy link
Contributor

@ajmyyra It's true the code is lacking support here. We typically let the field drive our development of functions to implement...and this appears to be one area the field has yet to need. If you've got a fix for it then by all means submit the PR! I'll be more than happy to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants