Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typed events vs legacy events #155

Open
0xean opened this issue Mar 22, 2023 · 1 comment · Fixed by #158
Open

Typed events vs legacy events #155

0xean opened this issue Mar 22, 2023 · 1 comment · Fixed by #158
Assignees
@asamere
Labels
help wanted Extra attention is needed

Comments

@0xean
Copy link
Collaborator

0xean commented Mar 22, 2023 •
edited
Loading

https://docs.cosmos.network/v0.46/core/events.html

We should move toward typed events

Acceptance Criteria

  1. Move all events emitted by the Arkeo module to types events
  2. Update sentinel and directory to handle type events in their listeners.
  3. make a call on wether we care enough about updating the Claim module to include typed events vs the time it would take to implement.
@0xean 0xean added the help wanted Extra attention is needed label Mar 22, 2023
@0xean 0xean mentioned this issue Mar 24, 2023
Closed
@asamere asamere linked a pull request Mar 24, 2023 that will close this issue
typed BondProvider event #158
Merged
@0xean 0xean reopened this Mar 27, 2023
@0xean
Copy link
Collaborator Author

0xean commented Mar 27, 2023

reopening since PR was just 1 part of the large modifications.

@0xean 0xean moved this to In Progress in Arkeo Launch Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asamere asamere

Labels
help wanted Extra attention is needed
Projects
Arkeo Launch
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

typed BondProvider event arkeonetwork/arkeo
2 participants
@asamere @0xean