Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't pick up extras_require #48

Open
Dreamsorcerer opened this issue Mar 15, 2022 · 3 comments
Open

Doesn't pick up extras_require #48

Dreamsorcerer opened this issue Mar 15, 2022 · 3 comments

Comments

@Dreamsorcerer
Copy link
Contributor

Dreamsorcerer commented Mar 15, 2022

Thanks for the quick fix. Currently, it doesn't seem to pick up anything from extras_require in setup.py.

I'm now seeing I900 'aioredis' not listed as a requirement etc. on https://github.com/aio-libs/aiocache/pull/561/files.

Would be great if support for that can be added.

@arkq
Copy link
Owner

arkq commented Mar 15, 2022

I think I know what you mean... but I'm afraid that it was never working like that. If I understand it correctly, you would like to collect requirements from requirements.txt, process the line "-r .[xxxx,yyy]" and then pickup requirements from setup.py (maybe even respecting selected extras in the brackets). Am I right?

@Dreamsorcerer
Copy link
Contributor Author

Ah, I thought it was already picking up the install_requires section. But, yes, that's what I mean.

@Dreamsorcerer
Copy link
Contributor Author

I think in our other repos we have a duplicated set of (pinned) requirements in the requirements.txt file, so I may have just assumed it was picking things up from setup.py/cfg, when it never was.

Maybe I'll just have to do the same thing to this repo (will probably make testing more reliable anyway).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants