Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation with contact not using OTR #18

Closed
azadi opened this issue Nov 27, 2014 · 2 comments
Closed

Conversation with contact not using OTR #18

azadi opened this issue Nov 27, 2014 · 2 comments
Labels

Comments

@azadi
Copy link
Collaborator

azadi commented Nov 27, 2014

When starting a conversation with a contact who is not using OTR, the message is:

2:41:23 pm - The current conversation is not private.
2:41:26 pm - You attempted to send an unencrypted message to sukhe. Unencrypted messages to this recipient are not allowed. Attempting to start a private conversation. Your message will be retransmitted when the private conversation starts.

I think we can word this better. Specifically, saying "Unencrypted messages to this recipient are not allowed" makes it seem like that this specific contact is the issue and not the fact that unencrypted conversations are not allowed as a policy.

A possible suggestion:

You attempted to send an unencrypted message to sukhe. This contact does not support encrypted communication and Tor Messenger does not allow unencrypted messages to be sent.

And then, in a separate message which follows (on a new line):

Attempting to start a private conversation. Your message will be retransmitted when the private conversation starts.

Something along these lines...

@azadi
Copy link
Collaborator Author

azadi commented Nov 27, 2014

In fact, on second thought, if the contact does not support encrypted communication in the first place, why do we attempt to start a private communication?

@arlolra
Copy link
Owner

arlolra commented Feb 20, 2015

Specifically, saying "Unencrypted messages to this recipient are not allowed" makes it seem like that this specific contact is the issue and not the fact that unencrypted conversations are not allowed as a policy.

Good point. I changed it to,

11:02:34 AM - You attempted to send an unencrypted message to testuser. As a policy, unencrypted messages are not allowed.
11:02:34 AM - Attempting to start a private conversation. Your message will be retransmitted when the private conversation starts.

In fact, on second thought, if the contact does not support encrypted communication in the first place, why do we attempt to start a private communication?

We don't know until we've exchanged a few messages with them (either the query msg or plaintext with whitespace tags). I've added #25 to provide better notification if the encrypted channel will never be setup.

@arlolra arlolra closed this as completed Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants