Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async key generation #20

Open
2 of 3 tasks
arlolra opened this issue Nov 29, 2014 · 4 comments
Open
2 of 3 tasks

Async key generation #20

arlolra opened this issue Nov 29, 2014 · 4 comments

Comments

@arlolra
Copy link
Owner

arlolra commented Nov 29, 2014

  • Add the ability generate keys asynchronously in a worker
  • Use the async worker to generate keys on account create, or as needed
  • If we somehow get to starting an OTR session w/o a key, grey out the conv browser with a message and throbber, and generate the key synchronously, rather than launching a modal
@azadi
Copy link
Collaborator

azadi commented Mar 2, 2015

I think this is a great idea, especially since we are enforcing private conversations by default, which means that all accounts will need to generate keys at one point or the other. On account create would be great.

arlolra added a commit that referenced this issue Jun 25, 2015
 * Part of #20

 * Next to use async notion for a better experience.
arlolra pushed a commit that referenced this issue Mar 14, 2016
@vqhuy
Copy link
Collaborator

vqhuy commented May 2, 2016

@arlolra : I am trying to resolve the task 3 but I am struggling to get the uiConv. I think I need to modify the method ui.generate but I cannot find any way to get the uiConv to grey out the conv browser. Do you have any idea?

@arlolra
Copy link
Owner Author

arlolra commented May 3, 2016

create_privkey_cb is called with only an accountname and protocol, which makes sense, given that it is going to generate a key to be used for all conversations with that pair. We probably need a utility like getUIConvForRecipient that returns all the matching conversations to be greyed out. Does that help?

@vqhuy
Copy link
Collaborator

vqhuy commented May 3, 2016

yup, I got it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants