Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement Balance retrieve #341

Merged
merged 2 commits into from
Mar 9, 2023

Conversation

victorcrimea
Copy link
Contributor

@victorcrimea victorcrimea commented Feb 14, 2023

Summary

This PR implements retrieval of Balance by optionally specifying AcccountId. Specifying AccountId creates a client clone under the hood in order to set the stripe_account header.

This affects #280 and #32

@arlyon
Copy link
Owner

arlyon commented Feb 20, 2023

Thanks for this! Gonna wait for CI and merge it.

@arlyon
Copy link
Owner

arlyon commented Feb 20, 2023

Looks like I'm going to have to pin the time crate version...

@arlyon
Copy link
Owner

arlyon commented Mar 3, 2023

Hey, I have bumped the msrv in line with time, could you please rebase?

@victorcrimea
Copy link
Contributor Author

@arlyon

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #341 (25a878a) into master (bdf813f) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master    #341      +/-   ##
=========================================
- Coverage    6.35%   6.35%   -0.01%     
=========================================
  Files         136     137       +1     
  Lines       20774   20779       +5     
=========================================
  Hits         1320    1320              
- Misses      19454   19459       +5     
Impacted Files Coverage Δ
src/resources/balance_ext.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@arlyon arlyon merged commit 9331631 into arlyon:master Mar 9, 2023
@arlyon
Copy link
Owner

arlyon commented Mar 9, 2023

Merged, thanks for using async stripe!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants