Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Linux, using a Typescript action #1

Closed
wants to merge 2 commits into from
Closed

Support Linux, using a Typescript action #1

wants to merge 2 commits into from

Conversation

BrettMayson
Copy link
Contributor

HEMTT will soon support Binarize on Linux

BrettMayson/HEMTT#670

@BrettMayson BrettMayson requested a review from Dahlgren October 18, 2024 09:35
@Dahlgren
Copy link
Member

You can do OS specific logic in the composite powershell step like for the mikero action, https://github.com/arma-actions/mikero-tools/blob/c5fd83d23121f25ad0ee9b7af274f676f3a56a94/action.yml#L8-L31
Adding all the JS code, especially the need to keep compiled dist files, is overly complicated for just downloading a zip, unpacking into a folder and setting up some registry entries

@BrettMayson
Copy link
Contributor Author

Yeah fair enough, I just really don't like using composite like that

@BrettMayson BrettMayson deleted the typescript branch October 19, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dahlgren Dahlgren Awaiting requested review from Dahlgren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrettMayson @Dahlgren