Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this a reusable React component? #28

Open
bnjbvr opened this issue Oct 31, 2020 · 3 comments
Open

Make this a reusable React component? #28

bnjbvr opened this issue Oct 31, 2020 · 3 comments

Comments

@bnjbvr
Copy link

bnjbvr commented Oct 31, 2020

Hi! Thanks for working on this, it's a fantastic project!
Would it make sense to make this easily reusable and export it on npm as react-riot-embed or something like this? It would be quite pleasant to be able to use it this way within another React app, and from what I've observed, not much work might be needed (but I'm speaking as one who just skimmed a few files, so I might be absurdly wrong!).

@arnav-t
Copy link
Owner

arnav-t commented Oct 31, 2020

Hi, @bnjbvr thanks for the feedback! 😀
Making this into an embeddable react component is indeed on the agenda next. Will get to it whenever I find the time.

@nzetsu
Copy link

nzetsu commented Aug 3, 2021

Hi!
@arnav-t, thank you for the inspiration and the motivation to do more with the cool stuffs matrix.org offers to us. When do you plan to continue to work on it?

@bnjbvr, The idea sounds so good! After rewritten a project website with react.js i noticed how fun it was and want to do a bit more with it. For ex. embedding the react component will be much fun to do and also usefull, since the project is for students in my uni. Cool you please elaborate a bit more what you plan to do or give some points so that i could start something and propose it?

Please notice, that i am actually not a cs student or has studied something in the field. I am just generally interested in building stuffs and for that i always have to learn new cool thecs.

@bnjbvr
Copy link
Author

bnjbvr commented Aug 3, 2021

@DiNaLo45 I don't plan to work on this myself, but I think one way to start would be to make the Client component public, and expose it from an index.jsx file; then make sure that nothing breaks when the component is instantiated. Then, reworking the lib to make styles customizable would surely be nice! (And I'd expect that the Matrix protocol has changed, so I'm not even sure if it would still work as is!)

Good luck, please keep us all up to date :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants