Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Talent Liste mit Default Werten extern in config Datei #2

Open
casibus opened this issue Dec 14, 2021 · 4 comments
Open

Talent Liste mit Default Werten extern in config Datei #2

casibus opened this issue Dec 14, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@casibus
Copy link
Collaborator

casibus commented Dec 14, 2021

No description provided.

@arnohakk
Copy link
Owner

Why should we do this? If a talent is equal to zero or an attribute is eight, they are not being stored in the .json file by Opolith.

@casibus
Copy link
Collaborator Author

casibus commented Dec 14, 2021

Code Style. In a class init method you do not like to have a long list of "data". Mostly for readability (both the code, as well as the "data")

@arnohakk
Copy link
Owner

So just move that to a separate file? There is some computation going on there still.

@arnohakk arnohakk added the enhancement New feature or request label Jan 6, 2022
@casibus
Copy link
Collaborator Author

casibus commented Jan 7, 2022

Hm jeah it is just not nice to have endless lines of code in the same script that contains the application flow. I will have a look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants