Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetty 9 - undeploy(Archive) should recursively remove handlers. #15

Open
joakime opened this issue Nov 18, 2013 · 4 comments
Open

Jetty 9 - undeploy(Archive) should recursively remove handlers. #15

joakime opened this issue Nov 18, 2013 · 4 comments

Comments

@joakime
Copy link
Contributor

joakime commented Nov 18, 2013

The existing assumption from Issue #12 about server.getHandlers() is also true for undeploy(Archive).

Also, the removeHandler logic assumption is incorrect.

See StandardUndeployer.java for details.

@starksm64
Copy link
Member

@joakime I assume we can delete all of these old issues?

@joakime
Copy link
Contributor Author

joakime commented Feb 17, 2022

The rules for handlers haven't changed in the past 15 years. I'll review these issues this week to see if they are still valid.

@joakime
Copy link
Contributor Author

joakime commented Feb 17, 2022

@starksm64 The arquillian core assumptions makes this difficult to implement.

@joakime
Copy link
Contributor Author

joakime commented Feb 17, 2022

The fixes in PR #17 only addresses a single deployed webapp, not multiple webapps, overlayed webapps, or nested webapps, or webapps behind other functionality (like gzip).

The points in issue #5 and #9 should be addressed, along with arquillian assumptions, for this to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants