Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change logging sent to Sentry to provide more meaningful information #212

Open
MatousJobanek opened this issue Jun 25, 2018 · 1 comment

Comments

@MatousJobanek
Copy link
Contributor

MatousJobanek commented Jun 25, 2018

When there is an error (eg. 404 returned from GH) there are two error records sent to Sentry.

  1. One for the actual problem:
    logged here: https://github.com/arquillian/ike-prow-plugins/blob/master/pkg/plugin/test-keeper/event_handler.go#L189
    the related issue in the sentry https://errortracking.prod-preview.openshift.io/openshift_io/ike-prow-plugins/issues/5663/

  2. And as the error is then returned back, then there is the second record sent to the Sentry from this place: https://github.com/arquillian/ike-prow-plugins/blob/master/pkg/plugin/test-keeper/event_handler.go#L44 (but will be from server.go when this PR is merged). However, this record doesn't provide meaningful information - here is an example of such a sentry issue https://errortracking.prod-preview.openshift.io/openshift_io/ike-prow-plugins/issues/5667/

So, change the logging sent to Sentry so the records/issues provide more meaningful information.

@MatousJobanek
Copy link
Contributor Author

MatousJobanek commented Jun 26, 2018

  • The duplicated logging is not necessary - change it so the error is logged only once.
  • The logged text shouldn't contain the JSON content (as it is now), but only the cause.

to the fields add:

anything else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant