Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(persist-web-storage): add init() to withIndexedDb #1031

Draft
wants to merge 2 commits into
base: v3
Choose a base branch
from
Draft

feat(persist-web-storage): add init() to withIndexedDb #1031

wants to merge 2 commits into from
+149 −155

Conversation

osovv
Copy link
Contributor

@osovv osovv commented Feb 4, 2025

closes #753

@stackblitz StackBlitz
Copy link

stackblitz bot commented Feb 4, 2025

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel Vercel
Copy link

vercel bot commented Feb 4, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
reatom ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 0:48am

@osovv osovv changed the title 753 async persist improvements feat(persist-web-storage): add init() to withIndexedDb Feb 4, 2025
@osovv
Copy link
Contributor Author

osovv commented Feb 5, 2025

I realized that we need to add async init() to reatomPersist with an empty default implementation.

I'll convert PR to draft until I refactor it

@osovv osovv marked this pull request as draft February 5, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@reatom/persist-web-storage garbage collection and asynchronous persistence initialization
1 participant
@osovv