Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a User, I can launch a request on any reader using a pre-defined date_range option [Continuation] #96

Closed
gabrielleberanger opened this issue Feb 8, 2021 · 0 comments · Fixed by #114
Assignees
Labels
new feature Creating a new feature P1 1st priority

Comments

@gabrielleberanger
Copy link
Contributor

gabrielleberanger commented Feb 8, 2021

WHY
Currently, only specific readers accept a --date_range parameter (it depends of the source API, that offers it or not).

Such a pre-defined --date_range option can be very convenient, in particular when conducting tests. In this case, you just have to specify --date-range PREVIOUS_WEEK for instance, instead of providing a specific --start-date and --end-date for your request.

HOW
Make the --date_range option available to all readers, including when it is not initially provided by the source API.

Case 1 - If the --date_range option is provided by the source API
Noting to do

Case 2 - If the --date_range option is not provided by the source API
Make the the option available, using the get_date_start_and_date_stop_from_date_range() function (available here). Here is the status of the implementation on readers falling within this scope:

  • DCM reader - To be done
  • SA360 - To be done
  • MyTarget - To be done
  • Adobe 2.0 - Implemented
  • Search Console - To be done
  • Twitter Reader - To be done
  • The Trade Desk - Implemented

Also see issue #67 for a description of how each reader handles date parameters.

@gabrielleberanger gabrielleberanger added new feature Creating a new feature P1 1st priority labels Feb 8, 2021
@pol-defont-reaulx pol-defont-reaulx self-assigned this Feb 24, 2021
@benoitgoujon benoitgoujon linked a pull request Feb 24, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature Creating a new feature P1 1st priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants