Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an extract archive activity (fixes #6) #9

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

djjuhasz
Copy link
Contributor

No description provided.

@djjuhasz djjuhasz requested review from sevein and jraddaoui April 17, 2024 18:56
@djjuhasz djjuhasz force-pushed the dev/issue-6-add-extract-archive branch from 675cf3f to 0109d7b Compare April 17, 2024 18:57
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 72.82609% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 77.20%. Comparing base (e97b26f) to head (a290271).

Files Patch % Lines
archive/extract_activity.go 71.26% 14 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main       #9      +/-   ##
==========================================
- Coverage   86.36%   77.20%   -9.16%     
==========================================
  Files           1        3       +2     
  Lines          44      136      +92     
==========================================
+ Hits           38      105      +67     
- Misses          3       17      +14     
- Partials        3       14      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djjuhasz djjuhasz force-pushed the dev/issue-6-add-extract-archive branch 3 times, most recently from 7699ad7 to 69b3c93 Compare April 17, 2024 21:13
Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @djjuhasz!

archive/extract_activity.go Outdated Show resolved Hide resolved
archive/extract_activity.go Outdated Show resolved Hide resolved
archive/extract_activity.go Outdated Show resolved Hide resolved
archive/extract_activity.go Show resolved Hide resolved
archive/extract_activity.go Outdated Show resolved Hide resolved
archive/extract_activity_test.go Outdated Show resolved Hide resolved
archive/extract_activity_test.go Show resolved Hide resolved
@djjuhasz djjuhasz requested a review from jraddaoui April 27, 2024 00:53
Copy link
Contributor

@jraddaoui jraddaoui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djjuhasz!

@djjuhasz djjuhasz force-pushed the dev/issue-6-add-extract-archive branch 2 times, most recently from 41e7b1b to 4d4ae82 Compare April 29, 2024 16:19
Change from a relative threshold for success (e.g. +/- 1% compared to
previous commit) to an absolute target (e.g. 70% or better coverage).
@djjuhasz djjuhasz force-pushed the dev/issue-6-add-extract-archive branch from 4d4ae82 to a290271 Compare April 29, 2024 16:21
@djjuhasz djjuhasz merged commit eae3871 into main Apr 29, 2024
6 checks passed
@djjuhasz djjuhasz deleted the dev/issue-6-add-extract-archive branch April 29, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants