chore: Increase strictness

artemeon · Mar 13, 2024 · b160ae1 · b160ae1
1 parent a88168b
commit b160ae1
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 15 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -3,5 +3,8 @@ includes:
 
 parameters:
     level: 9
+    checkUninitializedProperties: true
+    checkImplicitMixed: true
+    rememberPossiblyImpureFunctionValues: false
     paths:
         - src
diff --git a/src/Command/ConfigurationCommand.php b/src/Command/ConfigurationCommand.php
@@ -71,7 +71,7 @@ private function askForMantisUrl(): void
             label: 'The URL of your Mantis installation',
             placeholder: 'E.g. https://tickets.company.tld/',
             required: true,
-            validate: function ($value) {
+            validate: function (string $value) {
                 $parsedUrl = parse_url($value);
 
                 if ($parsedUrl === false) {
@@ -124,7 +124,7 @@ private function askForGitHubToken(): void
         $this->config['githubToken'] = $this->password(
             label: 'GitHub Personal Access Token',
             required: true,
-            validate: fn ($value) => !str_starts_with($value, 'ghp_') && str_starts_with($value, 'github_pat_')
+            validate: fn (string $value) => !str_starts_with($value, 'ghp_') && str_starts_with($value, 'github_pat_')
                 ? 'The provided value is not a valid GitHub PAT.'
                 : null,
         );
@@ -136,7 +136,7 @@ private function askForGitHubRepository(): void
             label: 'GitHub Repository(e.g. user/repository)',
             placeholder: 'E.g. user/repository',
             required: true,
-            validate: fn ($value) => count(explode('/', $value)) !== 2
+            validate: fn (string $value) => count(explode('/', $value)) !== 2
                 ? 'Invalid repository name.'
                 : null,
         );

diff --git a/src/Command/CreateGithubIssueFromMantisIssue.php b/src/Command/CreateGithubIssueFromMantisIssue.php
@@ -40,6 +40,7 @@ public function __invoke(): int
             return self::INVALID;
         }
 
+        /** @var string[] $ids */
         $ids = array_unique($idsArgument);
         $message = count($ids) !== 1 ? 'Creating issues ...' : 'Creating issue ...';
 

diff --git a/src/Command/IssuesListCommand.php b/src/Command/IssuesListCommand.php
@@ -77,7 +77,7 @@ public function __invoke(): int
 GRAPHQL;
 
         /** @var array{ repository: array<string, array{ title: string, url: string, closed: bool }> } $result */
-        $result = $this->githubConnector->graphql($query);
+        $result = $this->githubConnector->graphql($query)['data'];
         $githubResult = $result['repository'];
 
         switch ($this->option('output')) {

diff --git a/src/Helper/VersionHelper.php b/src/Helper/VersionHelper.php
@@ -52,7 +52,17 @@ public static function latestVersion(): ?string
             return null;
         }
 
-        return $packagist->getLatestRelease($packageName)['version'] ?? null;
+        $latestRelease = $packagist->getLatestRelease($packageName);
+        if (!is_array($latestRelease) || !array_key_exists('version', $latestRelease)) {
+            return null;
+        }
+
+        $version = $latestRelease['version'] ?? null;
+        if (!is_string($version)) {
+            return null;
+        }
+
+        return $version;
     }
 
     /**

diff --git a/src/Service/GithubConnector.php b/src/Service/GithubConnector.php
@@ -18,16 +18,13 @@ class GithubConnector
 
     public function __construct(?ConfigValues $config)
     {
-        if (!$config) {
-            return;
-        }
         $this->client = new Client([
             'headers' => [
                 'Accept' => 'application/vnd.github.v3+json',
-                'Authorization' => 'token ' . $config->getGithubToken(),
+                'Authorization' => 'token ' . $config?->getGithubToken(),
             ],
             'verify' => false,
-            'base_uri' => 'https://api.github.com/repos/' . $config->getGithubRepo() . '/',
+            'base_uri' => 'https://api.github.com/repos/' . $config?->getGithubRepo() . '/',
         ]);
     }
 

diff --git a/src/Service/MantisConnector.php b/src/Service/MantisConnector.php
@@ -19,16 +19,13 @@ class MantisConnector
 
     public function __construct(private ?ConfigValues $config)
     {
-        if (!$this->config) {
-            return;
-        }
         $this->client = new Client([
             'headers' => [
-                'Authorization' => $this->config->getMantisToken(),
+                'Authorization' => $this->config?->getMantisToken(),
                 'Content-Type' => 'application/json',
             ],
             'verify' => false,
-            'base_uri' => rtrim($this->config->getMantisUrl(), '/') . '/api/rest/issues/',
+            'base_uri' => rtrim($this->config?->getMantisUrl() ?? '', '/') . '/api/rest/issues/',
         ]);
     }