feat: remove is-builtin-module (#2703)

The node versions we support as per our engines constraint already have a built in function for determining if a module is built in. This removes the dependency and uses the built in function instead.
artilleryio · May 13, 2024 · 2344d60 · 2344d60
1 parent addd21d
commit 2344d60
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 24 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/artillery/lib/platform/aws-ecs/legacy/bom.js b/packages/artillery/lib/platform/aws-ecs/legacy/bom.js
@@ -2,7 +2,7 @@ const path = require('path');
 const fs = require('fs');
 const A = require('async');
 
-const isBuiltinModule = require('is-builtin-module');
+const { isBuiltin } = require('node:module');
 const detective = require('detective-es6');
 const depTree = require('dependency-tree');
 
@@ -240,7 +240,7 @@ function getCustomJsDependencies(context, next) {
       const npmPackages = requires
         .filter(
           (requireString) =>
-            !isBuiltinModule(requireString) && !isLocalModule(requireString)
+            !isBuiltin(requireString) && !isLocalModule(requireString)
         )
         .map((requireString) => {
           return requireString.startsWith('@')

diff --git a/packages/artillery/lib/platform/aws-lambda/dependencies.js b/packages/artillery/lib/platform/aws-lambda/dependencies.js
@@ -183,7 +183,6 @@ const createAndUploadLambdaZip = async (
       'uninstall',
       'dependency-tree',
       'detective',
-      'is-builtin-module',
       'try-require',
       'walk-sync',
       'esbuild-wasm',

diff --git a/packages/artillery/package.json b/packages/artillery/package.json
@@ -119,7 +119,6 @@
     "eventemitter3": "^4.0.4",
     "fs-extra": "^10.1.0",
     "got": "^11.8.5",
-    "is-builtin-module": "^2.0.0",
     "joi": "^17.6.0",
     "js-yaml": "^3.13.1",
     "jsonwebtoken": "^9.0.1",