Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for incorrect display and lua errors in notifications #13

Open
LaryIsland opened this issue May 24, 2023 · 0 comments
Open

Fix for incorrect display and lua errors in notifications #13

LaryIsland opened this issue May 24, 2023 · 0 comments

Comments

@LaryIsland
Copy link

Scrolling down the notification events category will cause lua error spam, as well as not properly displaying the options.

Removing the following lines from MSBTOptionsTabs.lua fixes the issue:

EventsTab_AddEvent(category, "NOTIFICATION_CHI_CHANGE", c.CHI_AMOUNT)
EventsTab_AddEvent(category, "NOTIFICATION_CHI_FULL", c.CHI_AMOUNT)
EventsTab_AddEvent(category, "NOTIFICATION_AC_CHANGE", c.AC_AMOUNT)
EventsTab_AddEvent(category, "NOTIFICATION_AC_FULL", c.AC_AMOUNT)

EventsTab_AddEvent(category, "NOTIFICATION_HOLY_POWER_CHANGE", c.HOLY_POWER_AMOUNT)
EventsTab_AddEvent(category, "NOTIFICATION_HOLY_POWER_FULL", c.HOLY_POWER_AMOUNT)
EventsTab_AddEvent(category, "NOTIFICATION_ESSENCE_CHANGE", c.ESSENCE_AMOUNT)
EventsTab_AddEvent(category, "NOTIFICATION_ESSENCE_FULL", c.ESSENCE_AMOUNT)

These options are also not necessary given that holy power, arcane charges, chi, and essence didn't exist in WotLK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant