Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Simulate an experimental slit as a post-process method #153

Open
erwanp opened this issue Dec 30, 2020 · 0 comments
Open
Labels
🚀 enhancement New feature or request

Comments

@erwanp
Copy link
Collaborator

erwanp commented Dec 30, 2020

Hello,

As I understand it, currently the Simulate an experimental slit checkbox changes the input parameter and recomputes the spectrum. Therefore, the slit is only applied at the spectrum calculation time (here in backend.py ).

It would be interesting to be able to simulate the experimental slit on a pre-computed spectrum. This is because on large databases, calculating the spectrum can take ~10-20s (or minutes / hours in other spectral codes!), whereas applying the slit is instantaneous.

This would allow :

  • users to apply and adjust (one parametrized Parameterize experimental slit #47 ) a slit after they have computed the spectrum. Which is something all equivalent softwares (ex: https://spectraplot.com) cannot do, although it's very useful for experimentalists !
  • to include alternative post-processing functions. For instance, many experimentalists want to plot the transmittance or the opacity instead of the radiance. Radis computes everything, and switching from emission mode ("radiance") to the absorption mode ("transmittance") or opacity ("abscoeff") would become as simple as ticking a checkbox.

Implementation wise, it requires to store the Spectrum object after it is computed, and apply a post-processing function + replot after .

  • @suzil is this hard given the current architecture ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant