Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maximum wavenumber is 3000 cm-1 #380

Open
minouHub opened this issue May 13, 2021 · 9 comments
Open

Maximum wavenumber is 3000 cm-1 #380

minouHub opened this issue May 13, 2021 · 9 comments
Labels
🏡 frontend frontend related stuff 😀 good first issue Good for newcomers

Comments

@minouHub
Copy link
Collaborator

Hello,

I'm using more and more this amazing app. However, I'm usually bothered by the limit at 3000 cm-1. Why such a limit?

Best,
Nicolas

@suzil
Copy link
Collaborator

suzil commented May 13, 2021

It's very arbitrary, sorry about that! Do you know what would be a good lower and upper bounds?

@minouHub
Copy link
Collaborator Author

don't be sorry, this work is amazing and has a bright future in my opinion. Btw, is there a way to check the trend of use?

I think that there are no limits. For the H2O molecule, the minimum wavenumber is 0.000084 cm-1 and the maximum is 25710.825500 cm-1. I don't know if it makes sens to go so low in wavenumber. I would (arbitrary!) suggest:

  • min : 1 cm-1
  • max : 30,000 cm-1

@suzil
Copy link
Collaborator

suzil commented May 13, 2021

Screen Shot 2021-05-13 at 6 19 01 PM

@minouHub is it OK now?

@minouHub
Copy link
Collaborator Author

amazing!

@suzil suzil closed this as completed May 14, 2021
@minouHub
Copy link
Collaborator Author

Two problems I didn't think about:

  1. it is now difficult to precisely aim with the cursor.
  2. Also, it is now tempting to perform calculations on very large ranges, which ultimately crashes the code.

Is it possible to allow for a larger scale but let the cursor navigate on 0 - 5000 cm-1? What do you think?

Sorry for reopening this issue

@suzil
Copy link
Collaborator

suzil commented May 14, 2021

All good! I'll make the adjustments to the scale.

We could potentially replace the range slider and just rely on the input boxes if that would be better with the larger range.

@suzil suzil reopened this May 14, 2021
@minouHub
Copy link
Collaborator Author

I don't really know what would the best for users. I want the best of the two:

  • I want to be able to simulate up the highest waverange I desire
  • I also want to use the range slider sometimes because it is very easy to use

Is there a way to allow up to very high, but have the slider range on 0-5000 cm-1? What do you think?

@erwanp
Copy link
Collaborator

erwanp commented Aug 11, 2022

Update on the scale . @arunavabasu-03 @suzil is it possible to have some kind of "log-scale spring slider"; i.e. :

initial position of the cursors would be approximately centered :
image

if I move a bit to the right, it allows me to make precise changes :

image

If I go further to the right, i get exponentially larger changes , i.e. :

image

Hence the "Log-scale effect"

Now, when I release the cursor, the two sides of the cursors spring-back to the initial position (approximately centered), but with the new range. This allows me to iterate quickly, and be very precise, from the new position.

image

In terms of UX I think it's quite good @minouHub

@minouHub
Copy link
Collaborator Author

hmmm funny now the cursor is on 2 lines for me
image

I really think the cursor is fine like this. I don't use it anyway because I usually know which bounds I want to simulate and directly type it

@arunavabasucom arunavabasucom added 😀 good first issue Good for newcomers 🏡 frontend frontend related stuff labels Sep 22, 2022
@arunavabasucom arunavabasucom moved this to To do in 🌱 Radis App Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏡 frontend frontend related stuff 😀 good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants