Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook added #688

Closed
wants to merge 2 commits into from
Closed

Conversation

Mohit-Aasirwal
Copy link

Title:

Storybook added for templating the components.

Description:

done with setting up UI for app and added storybook. Done with running on local machine and linting with ESlint.

Tasks done:

  1. Setting up the app on local machine.
  2. doing initial changes and fixing some platform issues to make app work.
  3. setting storybook for app.
  4. linting and code compilation

Related Issues

Successfully closes #669

Screenshots

image
Screenshot (416)

major changes

  1. disabled react imports in stories to cope up with eslint.
  2. disabled prettier to avoid "Delete CR" error.

Thanks!

@Mohit-Aasirwal Mohit-Aasirwal requested a review from suzil as a code owner March 29, 2023 14:29
@suzil
Copy link
Collaborator

suzil commented Mar 30, 2023

Running yarn storybook is failing for me. I think we're missing some configuration files?

Screenshot 2023-03-29 at 9 15 10 PM

Also these stories are not related to any components that are in this repo. It would be much more helpful to have some stories for components from this repo.

@Mohit-Aasirwal
Copy link
Author

I've found that .storybook is needed to run the storybook on local machine. you can try with npx sb init if you haven't already.
thanks.

@arunavabasucom
Copy link
Owner

@Mohit-Aasirwal thanks for this PR, closing this for now. I hope you will keep contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup storybook
3 participants