Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Support for attention masking #84

Closed
asagi4 opened this issue Dec 29, 2024 · 1 comment · Fixed by #88
Closed

[FR] Support for attention masking #84

asagi4 opened this issue Dec 29, 2024 · 1 comment · Fixed by #88

Comments

@asagi4
Copy link
Owner

asagi4 commented Dec 29, 2024

I really want to be able to use attention masking instead of ComfyUI's current whatever it's doing.

The existing implementations don't work with scheduled conds and seem difficult to adapt. IPAdapterPlus seems to have a good approach, but it's specialized for IPA conds so I can't quite steal it as is.

@asagi4
Copy link
Owner Author

asagi4 commented Jan 8, 2025

There's a test implementation of an attention mask hook using the patch_hooks2 pull request.

It seems to work, but is kind of slow. I'm not sure if the slowness is just a result of the masking, or if it's because ComfyUI isn't able to batch conds.

@asagi4 asagi4 linked a pull request Jan 12, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant