Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving error messages in case of double key in config #48

Open
iitzco-asapp opened this issue Aug 23, 2019 · 2 comments
Open

Improving error messages in case of double key in config #48

iitzco-asapp opened this issue Aug 23, 2019 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@iitzco-asapp
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When certain configs have a duplicate key in the config, then flambe fails with:

ruamel.yaml.constructor.ConstructorError: could not determine a constructor for the tag xxxx

I expect this happens with the ones that have a Runnable from an extension as top level object in the config

Describe the solution you'd like
The error message should be clear on what's happening:

The provided configuration file contains duplicated keys 'xxxx'
@nmatthews-asapp
Copy link
Contributor

@jeremyasapp we validated this is not the case with our current ruamel.yaml usage in v0.5, yes?

@jeremyasapp
Copy link
Contributor

Provided we use version > 0.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants