Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate CodeMirror mode from Ace mode as part of automated build #1

Open
mojavelinux opened this issue Dec 5, 2015 · 2 comments
Open

Comments

@mojavelinux
Copy link
Member

Generate the CodeMirror mode automatically from the Ace mode as part of a build using ace2cm. That way, we aren't attempting to modify auto-generated code.

This will entail setting up a gulp build.

@nerk
Copy link
Member

nerk commented Dec 5, 2015

This would be the preferred way to do it. However, the current code is already modified. This is the case with the part of the code contributed by the Ace-mode, as well as the code contributed by ace2cm.

We would need to extract the changes and submit 2 PRs, one to Ace and one to ace2cm. The code change to ace2cm might affect conversion of all other modes as well. I'm not sure if this is really worth the effort.

@mojavelinux
Copy link
Member Author

In light of that information, then I say we can treat it as non-generated code and just continue enhancing it as is. I was suggesting making it a part of the build if the code is 100% generated.

A next step, then, might be to cleanup the formatting so that it is easier to edit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants