Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Allow considering current cast time in spell cooldown #2095

Open
RamyRafik opened this issue Jul 4, 2023 · 0 comments
Open

[Feature] Allow considering current cast time in spell cooldown #2095

RamyRafik opened this issue Jul 4, 2023 · 0 comments

Comments

@RamyRafik
Copy link

RamyRafik commented Jul 4, 2023

Problem
Currently, spell cooldown icons allow considering GCD when calculating the icon duration. This is helpful when having a group ordered by icon duration (Acting as a Rotation Helper) to treat spells that will come off cooldown sooner then the GCD the same as others that are already off cooldown.
However, casters still have a similar issue with cast time. Example:
For a Demonology Warlock, casting Call Dreadstalkers (CD) takes priority over casting Hand of Gul'dan (HoG). A simple way to have a "Rotation Helper" is to put both spells in a Group ordered by Duration > ID, and have CD before HoG.
Problem happens during casting a spell (e.g. 2 seconds cast), when CD would come off cooldown in 1s, as the Group will show HoG first (As it doesn't have a cooldown), while the next spell in the priority list is HoG (As it will come off CD by the time casting finishes)

Suggestion
Allow Icon duration to be affected by Cast time, similar to how they cand be affected by GCD now.
This means that, during casting a spell, all Spell Cooldown icons should have a duration of Max(Icon_Duration, Current_Cast_Time)

Alternatives
The only other alternative is to code all Spell Cooldown icons in LUA, which is very cumbersome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants