fix: nodebuild call failure after initial install #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marko Kungla <[email protected]>
|
I opened #407 yesterday. It looks like it's related. |
|
#414 would also be fixed by this I think. |
|
@augustobmoura can you take a look at this one? I think it's a good fix to accommodate asdf 0.16.0+. |
Signed-off-by: Marko Kungla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
From
asdf version v0.16.0, this plugin breaks and fails when trying to install a Node version. This PR introduces a fix that addresses this issue forasdf >= v0.16.0while ensuring backward compatibility with older versions ofasdf.Changes Introduced:
asdf v0.16.0and later versions.v0.16.0.Testing:
asdf v0.16.0and v0.15.0 to verify proper functionality.asdf.Closes #407
Closes #412
Closes #414
Closes #415