Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update spark plugin #1051

Merged
merged 3 commits into from
Oct 6, 2024
Merged

fix: update spark plugin #1051

merged 3 commits into from
Oct 6, 2024

Conversation

jpm-halfspace
Copy link
Contributor

@jpm-halfspace jpm-halfspace commented Sep 19, 2024

The other spark plugin repo is broken

Summary

Description:

Updated the spark plugin repo to a working one.

Ran scripts/format.bash and it didn't report any changes. So I don't know why CI is failing...

  • Tool repo URL:
  • Plugin repo URL:

Checklist

  • Format with scripts/format.bash
  • Test locally with scripts/test_plugin.bash --file plugins/<your_new_plugin_name>
  • Your plugin CI tests are green
    • Tip: use the plugin_test action from asdf-actions in your plugin CI

The other spark plugin repo is broken
@jpm-halfspace jpm-halfspace requested a review from a team as a code owner September 19, 2024 14:21
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for raising. The tests were designed to test additions, not sure how they fair on removal or updates.

@jthegedus jthegedus changed the title Update spark fix: update spark plugin Oct 6, 2024
@jthegedus jthegedus merged commit dcceb16 into asdf-vm:master Oct 6, 2024
4 of 5 checks passed
@jpm-halfspace jpm-halfspace deleted the patch-1 branch November 20, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants