Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove Bin plugin that no longer exists #1057

Merged
merged 2 commits into from
Oct 5, 2024
Merged

fix: remove Bin plugin that no longer exists #1057

merged 2 commits into from
Oct 5, 2024

Conversation

jthegedus
Copy link
Contributor

@jthegedus jthegedus commented Oct 5, 2024 •
edited
Loading

Summary

Description:

  • Tool repo URL:
  • Plugin repo URL:

Checklist

  • Format with scripts/format.bash
  • Test locally with scripts/test_plugin.bash --file plugins/<your_new_plugin_name>
  • Your plugin CI tests are green
    • Tip: use the plugin_test action from asdf-actions in your plugin CI

@jthegedus jthegedus requested a review from a team as a code owner October 5, 2024 13:22
@jthegedus
Copy link
Contributor Author

The failure is expected as the tests are not clever enough to handle when we remove a plugin

@jthegedus jthegedus merged commit c9cfbe4 into master Oct 5, 2024
6 of 7 checks passed
@jthegedus jthegedus deleted the fix-rm-bin branch October 5, 2024 13:24
@jthegedus jthegedus mentioned this pull request Oct 5, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jthegedus