Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update jbang to new official location #890

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

maxandersen
Copy link
Contributor

Summary

Description: joschi jbang moved to jbang org so old url still works but
new one is preferred.

Background: jbangdev/jbang-asdf#2

Checklist

  • Format with scripts/format.bash
  • Test locally with scripts/test_plugin.bash --file plugins/<your_new_plugin_name>
  • Your plugin CI tests are green
    • Tip: use the plugin_test action from asdf-actions in your plugin CI

@maxandersen maxandersen marked this pull request as ready for review October 5, 2023 09:41
@maxandersen maxandersen requested a review from a team as a code owner October 5, 2023 09:41
@maxandersen
Copy link
Contributor Author

The tests locally fails saying readme missing link/name but it is there same with badge ci passing thus not sure why the test says it fails.

if someone can spot why it errors I would be happy :)

@jthegedus
Copy link
Contributor

jthegedus commented Nov 8, 2023

The tests locally fails saying readme missing link/name but it is there same with badge ci passing thus not sure why the test says it fails.

if someone can spot why it errors I would be happy :)

The links in the README are pointing to the old repo, so should also be updated. The diff shows only changes to the plugins/* dir. It can be fixed in a followup PR.

@jthegedus jthegedus merged commit 2f1017c into asdf-vm:master Nov 8, 2023
2 of 4 checks passed
mbutov pushed a commit to mbutov/asdf-plugins that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants