Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add import status logging #98

Merged
merged 10 commits into from
Aug 5, 2024
Merged

Add import status logging #98

merged 10 commits into from
Aug 5, 2024

Conversation

gertd
Copy link
Member

@gertd gertd commented Aug 1, 2024

This change adds the ImportStatus messages to the return flow of the bi-directional stream, enabling real-time status messages when message validation (content constraints) or model validation failures occur when handling the import stream.

The ImportStatus message contains

  • Code: the grpc status code
  • Msg: the grpc status message
  • Req: the import request that caused the error to be raised

@coveralls
Copy link

coveralls commented Aug 1, 2024

Pull Request Test Coverage Report for Build 10256425750

Details

  • 1 of 73 (1.37%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 24.805%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/directory/v3/importer.go 0 72 0.0%
Totals Coverage Status
Change from base Build 10062668157: -0.2%
Covered Lines: 859
Relevant Lines: 3463

💛 - Coveralls

@gertd gertd merged commit 34ba2d9 into main Aug 5, 2024
2 checks passed
@gertd gertd deleted the import-status branch August 5, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants