Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client secret is dropped from the authorize API call #252

Closed
dasuni-30 opened this issue Jul 23, 2024 · 0 comments
Closed

Client secret is dropped from the authorize API call #252

dasuni-30 opened this issue Jul 23, 2024 · 0 comments
Assignees
Labels
bug Something isn't working test-automation-required The issue/s fixed with this effort need to be covered with automated test

Comments

@dasuni-30
Copy link
Contributor

dasuni-30 commented Jul 23, 2024

Describe the issue:
Even if we pass the client secret along with the client id to the authorize API call, the client secret is dropped from the authorize API call in the auth-js-core level.

curl --location 'https://api.asgardeo.io/t/websdk/oauth2/authorize' \
--data-urlencode 'response_type=code' \
--data-urlencode 'client_id=XXX' \
--data-urlencode 'client_secret=XXX' \
--data-urlencode 'scope=openid internal_login profile' \
--data-urlencode 'redirect_uri=http://localhost:3000' \
--data-urlencode 'response_mode=direct' \
--data-urlencode 'code_challenge_method=S256' \
--data-urlencode 'code_challenge=XXX' \
--data-urlencode 'state=request_6'
Screenshot 2024-07-16 at 15 08 45

How to reproduce:
Try the authorize API call with client id and client secret.

Expected behavior:
We should be able to send the client secret since we are using the auth-js-core in both frontend(ex: react) and backend(ex: nodejs) frameworks

@dasuni-30 dasuni-30 added the bug Something isn't working label Jul 23, 2024
@pavinduLakshan pavinduLakshan added the test-automation-required The issue/s fixed with this effort need to be covered with automated test label Jul 23, 2024
@dasuni-30 dasuni-30 self-assigned this Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working test-automation-required The issue/s fixed with this effort need to be covered with automated test
Projects
None yet
Development

No branches or pull requests

2 participants