Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement- http request functionality to sample apps #262

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Enhancement- http request functionality to sample apps #262

wants to merge 2 commits into from

Conversation

s-vamshi
Copy link
Contributor

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.

resolves #123

Goals

Describe the solutions that this feature/fix will introduce to resolve the problems described above

Approach

Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.

User stories

Summary of user stories addressed by this change>

Release note

Brief description of the new feature or bug fix as it will appear in the release notes

Documentation

Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact

Training

Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable

Certification

Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.

Marketing

Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable

Automation tests

  • Unit tests

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

List any other related PRs

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@s-vamshi s-vamshi mentioned this pull request Oct 29, 2024
Open
@s-vamshi
Copy link
Contributor Author

Hey @pavinduLakshan can you please check this draft pr and let me know if I am on the right track?

@s-vamshi
Copy link
Contributor Author

Hey @pavinduLakshan can you please review this draft pr?

pavinduLakshan
pavinduLakshan reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@pavinduLakshan pavinduLakshan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @s-vamshi , thank you for sending a PR and sincere apologies for the delay in reviewing. I have added a couple of comments. If you still have some time, could u kindly go through and address those?

Also, it'd be great if you can add a screencast/screenshot of the final UI (of the entire page) to get an idea how this new information would view.

samples/asgardeo-react-app/src/components/authentication-response.tsx
const [resp, setResp] = useState<object>({});

const { httpRequest } = useAuthContext();
const requestConfig: HttpRequestConfig = {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const requestConfig: HttpRequestConfig = {
const requestConfig: HttpRequestConfig = {

samples/asgardeo-react-app/src/config.json
@@ -3,5 +3,5 @@
"baseUrl": "",
"signInRedirectURL": "https://localhost:3000",
"signOutRedirectURL": "https://localhost:3000",
"scope": ["profile"]
"scope": ["internal_login"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep both scope values.

Suggested change
"scope": ["internal_login"]
"scope": ["profile", "internal_login"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavinduLakshan pavinduLakshan pavinduLakshan left review comments

@brionmario brionmario Awaiting requested review from brionmario brionmario will be requested when the pull request is marked ready for review brionmario is a code owner

@NipuniBhagya NipuniBhagya Awaiting requested review from NipuniBhagya NipuniBhagya will be requested when the pull request is marked ready for review NipuniBhagya is a code owner

@inthirakumaaran inthirakumaaran Awaiting requested review from inthirakumaaran inthirakumaaran will be requested when the pull request is marked ready for review inthirakumaaran is a code owner

@jeradrutnam jeradrutnam Awaiting requested review from jeradrutnam jeradrutnam will be requested when the pull request is marked ready for review jeradrutnam is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add httpRequest functionality to sample apps
2 participants
@s-vamshi @pavinduLakshan