Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate the default Sample to Vite #250

Open
1 task
brionmario opened this issue Oct 4, 2024 · 2 comments
Open
1 task

Migrate the default Sample to Vite #250

brionmario opened this issue Oct 4, 2024 · 2 comments

Comments

@brionmario
Copy link
Member

brionmario commented Oct 4, 2024

Is your suggestion related to an experience ? Please describe.

The current default sample is written with a custom webpack.config. The initial thought process at the time was that the app should be minimal and should install and startup fairly easily since, at the time, Create React App (CRA) was extremely slow and had a lot of boilerplate code.

However, over time, we realized that people actually try out the SDK and build their apps on top of the sample. This leads to challenges where developers need to deal with webpack quite a bit to get the application production-ready, such as:

  • Adding a base path for the application has to be done manually.
  • Certain media types not supported by default loaders require manual configuration.
  • Adjusting webpack settings for performance optimizations (like code splitting, tree-shaking) is not intuitive for users unfamiliar with the tool.
  • Custom handling of environment variables and builds for different deployment environments.
  • Lack of automatic support for modern JavaScript/TypeScript features without additional babel configuration.

Describe the improvement

  • Migrate default sample to Vite which is the trending React app scaffolding tool at the moment.

Additional context

Also consider whether using https://github.com/asgardeo/asgardeo-vite-react-template would fast things up.

@Rishi-0007
Copy link

Hey @brionmario , I will try to solve this issue. Please assign this to me.

@vickywane
Copy link

@brionmario It appears there have been no recent changes to this.

Can I take it up?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants