Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About NeRF Dataset #109

Open
2j1ejyu opened this issue Sep 17, 2022 · 2 comments
Open

About NeRF Dataset #109

2j1ejyu opened this issue Sep 17, 2022 · 2 comments

Comments

@2j1ejyu
Copy link

2j1ejyu commented Sep 17, 2022

Thanks for the great repo!

If I understood the code correctly, the NeRF Dataset in your code (nerf/provider.py) is getting each batch from the same image rays, randomly sampling, which is different from the original NeRF Dataset.
I want to ask if there's a reason you coded this way and also want to ask if there would be any performance degradation

  1. since training with rays in the same image could bother training the scene generally(this is just my opinion) and
  2. since the rays are sampled randomly, some rays could be less trained
@ashawkey
Copy link
Owner

@2j1ejyu Hi, these two behaviours in fact follow instant-ngp. In some early experiments I don't find these will cause significant performance degradation. You can modify them and try!

@2j1ejyu
Copy link
Author

2j1ejyu commented Sep 18, 2022

thank you so much for your quick reply! Have nice day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants