Add support for using custom Environments and Strategies ⚡
#608
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #608 +/- ##
==========================================
- Coverage 83.24% 78.60% -4.65%
==========================================
Files 11 12 +1
Lines 376 430 +54
==========================================
+ Hits 313 338 +25
- Misses 63 92 +29 ☔ View full report in Codecov by Sentry. |
|
@amorehead Can you explain your rationale behind adding these additional configs? Super curious to know your thought process. Is it related to PyTorch Lighting's use of a "strategy" defined here: https://lightning.ai/docs/pytorch/stable/extensions/strategy.html? And some example strategies: 
|
|
Hey, @gil2rok. Yes, Lightning's |
Because this pull request has not been accepted, how did you use these advanced strategies? Did you just manually add them the PyTorch Lightning trainer arguments? |
| callbacks=callbacks, | ||
| logger=logger, | ||
| plugins=plugins, | ||
| strategy=strategy, |
There was a problem hiding this comment.
As you can see here, now one can specify an optional strategy for Lightning to use e.g., via OmegaConf YAML config files.
What does this PR do?
Adds the ability for one to employ custom (e.g., Lightning Fabric)
Environments(e.g.,SlurmEnvironment) andStrategies(e.g.,DeepSpeedStrategy) during model training or evaluation.Before submitting
pytestcommand?pre-commit run -acommand?Did you have fun?
Make sure you had fun coding 🙃 ⚡