Skip to content

Commit

Permalink
SKA: Fix outdated eslint rules (elastic#206961)
Browse files Browse the repository at this point in the history 
## Summary

Some eslint rules' paths were outdated after the SKA relocations.
This PR aims at fixing them.

---------

Co-authored-by: kibanamachine <[email protected]>
  • Loading branch information
@gsoldevila @kibanamachine
gsoldevila and kibanamachine authored Jan 28, 2025
1 parent 56d508f commit c347582
Show file tree
Hide file tree
Showing 168 changed files with 1,506 additions and 185 deletions.
3 changes: 0 additions & 3 deletions .eslintignore
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ snapshots.js
!.buildkite

# plugin overrides
/src/core/lib/kbn_internal_native_observable
/src/platform/plugins/shared/data/common/es_query/kuery/ast/_generated_/**
/x-pack/platform/plugins/private/canvas/canvas_plugin
/x-pack/platform/plugins/private/canvas/shareable_runtime/build
Expand All @@ -33,10 +32,8 @@ snapshots.js
/packages/kbn-eslint-config
/packages/kbn-plugin-generator/template
/packages/kbn-generate/templates
/packages/kbn-pm/dist
/packages/kbn-test/src/functional_test_runner/__tests__/fixtures/
/packages/kbn-test/src/functional_test_runner/lib/config/__tests__/fixtures/
/packages/kbn-ui-framework/dist
/src/platform/packages/shared/kbn-flot-charts/lib
/src/platform/packages/shared/kbn-monaco/src/**/antlr
/src/platform/packages/shared/kbn-esql-ast/src/**/antlr
Expand Down
56 changes: 33 additions & 23 deletions .eslintrc.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,10 @@ module.exports = {
'src/**/*.{js,mjs,ts,tsx}',
'x-pack/**/*.{js,mjs,ts,tsx}',
'packages/**/*.{js,mjs,ts,tsx}',
'src/platform/packages/**/*.{js,mjs,ts,tsx}',
'src/core/packages/**/*.{js,mjs,ts,tsx}',
'x-pack/platform/packages/**/*.{js,mjs,ts,tsx}',
'x-pack/solutions/*/packages/**/*.{js,mjs,ts,tsx}',
],
plugins: ['formatjs'],
rules: {
Expand Down Expand Up @@ -924,7 +928,7 @@ module.exports = {
'x-pack/solutions/observability/plugins/exploratory_view/**/*.{js,mjs,ts,tsx}',
'x-pack/solutions/observability/plugins/ux/**/*.{js,mjs,ts,tsx}',
'x-pack/solutions/observability/plugins/slo/**/*.{js,mjs,ts,tsx}',
'x-pack/packages/observability/**/*.{js,mjs,ts,tsx}',
'x-pack/solutions/observability/packages/**/*.{js,mjs,ts,tsx}',
],
rules: {
'no-console': ['warn', { allow: ['error'] }],
Expand All @@ -944,7 +948,7 @@ module.exports = {
'x-pack/solutions/observability/plugins/observability/**/*.stories.*',
'x-pack/solutions/observability/plugins/exploratory_view/**/*.stories.*',
'x-pack/solutions/observability/plugins/slo/**/*.stories.*',
'x-pack/packages/observability/**/*.{js,mjs,ts,tsx}',
'x-pack/solutions/observability/packages/**/*.{js,mjs,ts,tsx}',
],
rules: {
'react/function-component-definition': [
Expand All @@ -958,9 +962,10 @@ module.exports = {
},
{
files: [
'x-pack/plugins/observability_solution/**/*.{ts,tsx}',
'x-pack/plugins/{streams,streams_app}/**/*.{ts,tsx}',
'x-pack/packages/observability/**/*.{ts,tsx}',
'x-pack/platform/plugins/shared/observability_solution/**/*.{ts,tsx}',
'x-pack/solutions/observability/plugins/**/*.{ts,tsx}',
'x-pack/solutions/observability/plugins/{streams,streams_app}/**/*.{ts,tsx}',
'x-pack/solutions/observability/packages/**/*.{ts,tsx}',
],
rules: {
'react-hooks/exhaustive-deps': [
Expand All @@ -975,17 +980,17 @@ module.exports = {
{
files: [
'x-pack/platform/plugins/shared/aiops/**/*.tsx',
'x-pack/plugins/observability_solution/**/*.tsx',
'x-pack/plugins/{streams,streams_app}/**/*.{ts,tsx}',
'src/plugins/ai_assistant_management/**/*.tsx',
'x-pack/packages/observability/**/*.{ts,tsx}',
'x-pack/platform/plugins/shared/observability_solution/**/*.{ts,tsx}',
'x-pack/solutions/observability/plugins/**/*.{ts,tsx}',
'src/platform/plugins/shared/ai_assistant_management/**/*.tsx',
'x-pack/solutions/observability/packages/**/*.{ts,tsx}',
],
rules: {
'@kbn/telemetry/event_generating_elements_should_be_instrumented': 'error',
},
},
{
files: ['x-pack/plugins/search*/**/*.tsx', 'x-pack/packages/search/**/*.tsx'],
files: ['x-pack/solutions/search/**/*.tsx'],
rules: {
'@kbn/telemetry/event_generating_elements_should_be_instrumented': 'warn',
},
Expand All @@ -994,7 +999,7 @@ module.exports = {
files: [
'x-pack/solutions/observability/plugins/**/!(*.stories.tsx|*.test.tsx|*.storybook_decorator.tsx|*.mock.tsx)',
'x-pack/solutions/observability/packages/**/!(*.stories.tsx|*.test.tsx|*.storybook_decorator.tsx|*.mock.tsx)',
'src/plugins/ai_assistant_management/**/!(*.stories.tsx|*.test.tsx|*.storybook_decorator.tsx|*.mock.tsx)',
'src/platform/plugins/shared/ai_assistant_management/**/!(*.stories.tsx|*.test.tsx|*.storybook_decorator.tsx|*.mock.tsx)',
],
rules: {
'@kbn/i18n/strings_should_be_translated_with_i18n': 'warn',
Expand Down Expand Up @@ -1097,8 +1102,8 @@ module.exports = {
'x-pack/platform/plugins/private/data_visualizer/**/*.{js,mjs,ts,tsx}',
'x-pack/platform/plugins/shared/ml/**/*.{js,mjs,ts,tsx}',
'x-pack/platform/plugins/private/transform/**/*.{js,mjs,ts,tsx}',
'x-pack/packages/private/ml/**/*.{js,mjs,ts,tsx}',
'x-pack/packages/shared/ml/**/*.{js,mjs,ts,tsx}',
'x-pack/platform/packages/shared/ml/**/*.{js,mjs,ts,tsx}',
'x-pack/platform/packages/private/ml/**/*.{js,mjs,ts,tsx}',
],
rules: {
'@typescript-eslint/consistent-type-imports': 'error',
Expand Down Expand Up @@ -1568,15 +1573,22 @@ module.exports = {
{
// typescript for front and back end
files: [
'x-pack/plugins/{alerting,stack_alerts,actions,task_manager,event_log}/**/*.{ts,tsx}',
'x-pack/platform/plugins/shared/alerting/**/*.{ts,tsx}',
'x-pack/platform/plugins/shared/stack_alerts/**/*.{ts,tsx}',
'x-pack/platform/plugins/shared/actions/**/*.{ts,tsx}',
'x-pack/platform/plugins/shared/task_manager/**/*.{ts,tsx}',
'x-pack/platform/plugins/shared/event_log/**/*.{ts,tsx}',
],
rules: {
'@typescript-eslint/no-explicit-any': 'error',
},
},
{
// typescript only for back end
files: ['x-pack/plugins/{stack_connectors,triggers_actions_ui}/server/**/*.ts'],
files: [
'x-pack/platform/plugins/shared/stack_connectors/server/**/*.ts',
'x-pack/platform/plugins/shared/triggers_actions_ui/server/**/*.ts',
],
rules: {
'@typescript-eslint/no-explicit-any': 'error',
},
Expand Down Expand Up @@ -1708,7 +1720,7 @@ module.exports = {
// All files
files: [
'x-pack/solutions/search/plugins/serverless_search/**/*.{ts,tsx}',
'packages/kbn-search-*',
'x-pack/solutions/search/packages/kbn-search-*',
],
rules: {
'@kbn/telemetry/event_generating_elements_should_be_instrumented': 'error',
Expand Down Expand Up @@ -1872,7 +1884,8 @@ module.exports = {
'x-pack/test/encrypted_saved_objects_api_integration/**/*.{js,mjs,ts,tsx}',

'x-pack/platform/plugins/shared/security/**/*.{js,mjs,ts,tsx}',
'x-pack/packages/security/**/*.{js,mjs,ts,tsx}',
'x-pack/platform/packages/private/security/**/*.{js,mjs,ts,tsx}',
'x-pack/platform/packages/shared/security/**/*.{js,mjs,ts,tsx}',
'x-pack/test/security_api_integration/**/*.{js,mjs,ts,tsx}',
'x-pack/test/security_functional/**/*.{js,mjs,ts,tsx}',

Expand Down Expand Up @@ -1927,7 +1940,6 @@ module.exports = {
{
files: [
'src/platform/packages/shared/kbn-analytics/**',
// 'packages/kbn-telemetry-tools/**',
'src/platform/plugins/private/kibana_usage_collection/**',
'src/platform/plugins/shared/usage_collection/**',
'src/platform/plugins/shared/telemetry/**',
Expand All @@ -1948,7 +1960,6 @@ module.exports = {
'x-pack/platform/plugins/shared/global_search/**',
'x-pack/platform/plugins/shared/cloud/**',
'src/platform/packages/shared/kbn-config-schema',
'src/plugins/status_page/**',
'src/platform/plugins/shared/saved_objects_management/**',
'src/platform/packages/shared/kbn-analytics/**',
'packages/kbn-telemetry-tools/**',
Expand All @@ -1973,10 +1984,9 @@ module.exports = {
{
files: [
'src/core/{server,public,common}/index.ts',
'src/plugins/*/{server,public,common}/index.ts',
'src/plugins/*/*/{server,public,common}/index.ts',
'x-pack/plugins/*/{server,public,common}/index.ts',
'x-pack/plugins/*/*/{server,public,common}/index.ts',
'src/platform/plugins/**/{server,public,common}/index.ts',
'x-pack/platform/plugins/**/{server,public,common}/index.ts',
'x-pack/solutions/*/plugins/**/{server,public,common}/index.ts',
],
rules: {
'@kbn/eslint/no_export_all': 'error',
Expand Down
3 changes: 2 additions & 1 deletion src/platform/plugins/private/url_forwarding/public/index.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ import { UrlForwardingPlugin } from './plugin';

export const plugin = () => new UrlForwardingPlugin();

export * from './plugin';
export type { ForwardDefinition, UrlForwardingSetup, UrlForwardingStart } from './plugin';
export { UrlForwardingPlugin } from './plugin';
21 changes: 18 additions & 3 deletions src/platform/plugins/shared/charts/public/index.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,24 @@ export const plugin = () => new ChartsPlugin();

export type { ChartsPluginSetup, ChartsPluginStart } from './plugin';

export * from './static';
export * from './services/palettes/lighten_color';
export * from './services/palettes/decrease_opacity';
export {
createColorPalette,
seedColors,
CurrentTime,
EmptyPlaceholder,
useCommonChartStyles,
Endzones,
getAdjustedInterval,
renderEndzoneTooltip,
Warnings,
ColorPickerLazy,
ColorPicker,
LegendToggleLazy,
LegendToggle,
MULTILAYER_TIME_AXIS_STYLE,
} from './static';
export { lightenColor } from './services/palettes/lighten_color';
export { decreaseOpacity } from './services/palettes/decrease_opacity';
export { useActiveCursor } from './services/active_cursor';

export interface ClickTriggerEvent {
Expand Down
Loading

0 comments on commit c347582

Please sign in to comment.