Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer Misalignment #327

Closed
saadgibawa opened this issue Oct 31, 2024 · 13 comments
Closed

Footer Misalignment #327

saadgibawa opened this issue Oct 31, 2024 · 13 comments
Assignees
Labels
gssoc-ext Indicates Contributions made to GSSoC Extended'24

Comments

@saadgibawa
Copy link
Contributor

The footer is not aligned properly, resulting in an uneven or uncentered appearance, which disrupts the layout and visual balance of the page. This misalignment affects the user experience, particularly on larger screens where the footer sections may appear disproportionate or disorganized.
Screenshot 2024-10-31 115108

@aslams2020
Copy link
Owner

aslams2020 commented Oct 31, 2024

Currently, Someone is working on footer. Will assign you after that work is complete.
To avoid later conflicts.

@saadgibawa
Copy link
Contributor Author

Sure!

@aslams2020 aslams2020 removed the on hold label Nov 2, 2024
@aslams2020 aslams2020 added the gssoc-ext Indicates Contributions made to GSSoC Extended'24 label Nov 2, 2024
@aslams2020
Copy link
Owner

@saadgibawa You can start working on it. level will be assigned based on the work

@saadgibawa
Copy link
Contributor Author

Okay

@saadgibawa
Copy link
Contributor Author

@aslams2020 Hey! I have been working on the footer section alignment issue for a few days now. I've tried pretty much everything I can think of and even did some research, but I still haven't gotten anywhere. Right now, it looks like this:
Screenshot 2024-11-06 211913

Here's how it currently looks:
image

Please help me out with this

@aslams2020
Copy link
Owner

Maybe you can include the footer section present in home page as it is in other pages?

@saadgibawa
Copy link
Contributor Author

I’ve tried adding the footer from the homepage to the other pages, but the alignment problem is still there.

@aslams2020
Copy link
Owner

Try if you can make some slightly better than it is currently misaligned.
we will merge it as we need to fix it so it's better than nothing

@saadgibawa
Copy link
Contributor Author

I figured out what exactly was causing the footer misalignment on all the pages and got it fixed.
Now it looks like this:
image
But the bottom gap is still there so I'm currently reviewing the entire code to understand why the gap won’t go away. It's going to take me a bit to fix the bottom gap. I’ll let you know when I’m all done! Appreciate the help though!

@aslams2020
Copy link
Owner

Yeah, let me know when it's done!

@saadgibawa
Copy link
Contributor Author

I'm done with this issue and raised a PR just now. Please review it. Thanks!

@saadgibawa
Copy link
Contributor Author

Also at present the logo in the footer section of stickers and blogs page is not aligned
image
Should i fix this also if it is not assigned to someone else?

@aslams2020
Copy link
Owner

Let it be for now, will review and merge your PR.
if you found some more bugs, you can raise one issue to solve them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Indicates Contributions made to GSSoC Extended'24
Projects
None yet
Development

No branches or pull requests

2 participants