Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not declare _typecheck[_test] target when using tsc as transpiler #721

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Oct 18, 2024

Declaring the _typecheck[_test] targets is only required when tsc is not doing the typechecking while transpiling something.

We did add the _types target 100% of the time, transpiler(s) or not. I think we should keep that target 100% of the time. But when should the _typecheck[_test] targets be added? This reverts back to be more like before #705 where they only exist if tsc will not do type-checking in a different action.

Fix #719


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

Copy link

aspect-workflows bot commented Oct 18, 2024

Test

3 test targets passed

Targets
//examples/transpiler:custom_dts_transpiler-no_declarations-test [k8-fastbuild] 21ms
//examples/transpiler:custom_dts_transpiler-test [k8-fastbuild]                 26ms
//examples/transpiler:typecheck_fail-custom_transpilers_test [k8-fastbuild]     26ms

Total test execution time was 73ms. 97 tests (97.0%) were fully cached saving 8s.


Buildifier      Format

@jbedard
Copy link
Member Author

jbedard commented Oct 30, 2024

So far voters are in favour of keeping this target which I also agree with, so converting to draft for now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Superfluous @ts_project_typecheck_test target being generated with v3.2.0
1 participant