fix: do not declare _typecheck[_test] target when using tsc as transpiler #721
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Declaring the
_typecheck[_test]
targets is only required when tsc is not doing the typechecking while transpiling something.We did add the
_types
target 100% of the time, transpiler(s) or not. I think we should keep that target 100% of the time. But when should the_typecheck[_test]
targets be added? This reverts back to be more like before #705 where they only exist if tsc will not do type-checking in a different action.Fix #719
Changes are visible to end-users: no
Test plan