Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for Sample should be explicit in column name for publication year #50

Open
Rensvandeschoot opened this issue Oct 11, 2024 · 0 comments
Assignees

Comments

@Rensvandeschoot
Copy link
Member

See the feedback provided by @RiannevanderFeen in asreview/asreview#1853 (reply in thread)

 it says the publication year column is missing.

File "(...)Python312\site-packages\asreviewcontrib\datatools\sample.py", line 13, in sample
raise ValueError(f"• The input file should have a {year_column} column.")
ValueError: • The input file should have a publication_year column.

It seems like I fixed this by changing the "year" column to "publication_year" in the Excel file.

We could improve the error message or add year as a recognizable column name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants