Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid lap seen as a valid bestLap #272

Open
Renegade89 opened this issue Feb 2, 2024 · 2 comments
Open

Invalid lap seen as a valid bestLap #272

Renegade89 opened this issue Feb 2, 2024 · 2 comments

Comments

@Renegade89
Copy link

Not much to tell otherwise than the title already does.

Lap 1: valid 2:25.000
Lap 2: invalid 2:23.500

Lap 2 becomes bestLap, although invalid.

So this variable should only be updated if the lap is flagged valid.

@pedrofaria
Copy link
Collaborator

I made some changes to check for valid laps in a more strict way.. lets see

@Renegade89
Copy link
Author

Tested this one quickly just now. The bestlap variable seems to update still even with invalid laps driven.

The log shows :

New laptime: 138320 for carId 1162 with lapstates: HasCut, (raw 1)`

Flags do not appear to be right on my end, as for this car it shows flags : 0 in the jsondata

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants