Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing issues with Deno 1.0.2 #1

Open
tedre191 opened this issue May 28, 2020 · 1 comment
Open

Typing issues with Deno 1.0.2 #1

tedre191 opened this issue May 28, 2020 · 1 comment

Comments

@tedre191
Copy link

Hi,

I was hoping to try out your lib but I'm getting typing issues with Deno 1.0.2/TypeScript 3.9.2, mainly around the "globalThis" object, and some implicit 'any' types.

TS7053 [ERROR]: Element implicitly has an 'any' type because expression of type '"SERVICER_GLOBAL_SINGLETON_KEY"' can't be used to index type 'typeof globalThis'. Property 'SERVICER_GLOBAL_SINGLETON_KEY' does not exist on type 'typeof globalThis'. const s: Servicr = globalThis[key];
``

I'd be glad to spend time later this week to try to fix it, but I'd like to know first if you are accepting Pull requests for the project?
Is this still a maintained project? I'm seeing that last commit is 4 months old.

Thanks!

@astanciu
Copy link
Owner

astanciu commented May 28, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants