Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sequencer app refactor #1810

Open
2 of 4 tasks
ethanoroshiba opened this issue Nov 12, 2024 · 2 comments
Open
2 of 4 tasks

Sequencer app refactor #1810

ethanoroshiba opened this issue Nov 12, 2024 · 2 comments
Assignees
@ethanoroshiba
Labels
ignore-stale Override for issues or PRs which should not be removed if stale. refactor code refactoring or maintainence sequencer pertaining to the astria-sequencer crate

Comments

@ethanoroshiba
Copy link
Contributor

ethanoroshiba commented Nov 12, 2024 •
edited by SuperFluffy
Loading

After offline discussion, I have put together a list of issues which will hopefully improve our code quality along with outside readability in the sequencer app. The list is in order of which things should be accomplished first:

Tasks
Preview Give feedback
  1. sequencer: move all ActionHandler impls to a central location #1657
    code-quality sequencer
    ethanoroshiba
  2. sequencer: refactor app #1785
    refactor sequencer
    ethanoroshiba
  3. rename and refactor begin_block and end_block #1809
    code-quality ignore-stale refactor sequencer
    ethanoroshiba
  4. sequencer: refactor code duplication in app::process_proposal #1835
    code-quality ignore-stale refactor sequencer tech-debt

┆Issue Number: ENG-1007
@ethanoroshiba ethanoroshiba added sequencer pertaining to the astria-sequencer crate refactor code refactoring or maintainence labels Nov 12, 2024
@ethanoroshiba ethanoroshiba self-assigned this Nov 12, 2024
@joroshiba
Copy link
Member

This issue is stale because it has been open 45 days with no activity. Remove stale label or this issue
be closed in 7 days.

@joroshiba joroshiba added the stale label Jan 5, 2025
@ethanoroshiba ethanoroshiba added ignore-stale Override for issues or PRs which should not be removed if stale. and removed stale labels Jan 6, 2025
@ethanoroshiba
Copy link
Contributor Author

Noting that I have put the ignore-stale label on this issue since the PR to close it is waiting to be reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethanoroshiba ethanoroshiba

Labels
ignore-stale Override for issues or PRs which should not be removed if stale. refactor code refactoring or maintainence sequencer pertaining to the astria-sequencer crate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joroshiba @ethanoroshiba