Behaviour of precompute transforms with kernel = None
default unclear
#247
Labels
documentation
Improvements or additions to documentation
kernel = None
default unclear
#247
Both the forward and inverse precompute transforms default to a value of
None
for theirkernel
argument and the corresponding docstrings indicate this argument is optional:s2fft/s2fft/precompute_transforms/spherical.py
Lines 14 to 23 in 7cf80bb
s2fft/s2fft/precompute_transforms/spherical.py
Lines 289 to 298 in 7cf80bb
Looking through the underlying implementations though, I cannot spot any logic for handling a
kernel is None
case with thekernel
value passed as is in to a call toeinsum
.I think we probably either want to remove the
None
defaults (and optional labels in the docstrings) or add some logic for automatically computing an appropriate value forkernel
if left as the defaultNone
?The text was updated successfully, but these errors were encountered: