You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @PhilippMisofCH, thanks for flagging this, agreed this looks like a mistake in the documentation (or if not something that needs clarifying!).
@CosmoMatt it looks like the ordering in the returned shape was permuted in 0339538 as part of #134 but the docstring wasn't updated then. Assuming the correct fix is therefore to update the docstring to be consistent the ordering now asssumed in the code?
The documentation of the$\beta, \alpha, \gamma$
sampling.so3_samples.f_shape
function claims that the storage scheme iss2fft/s2fft/sampling/so3_samples.py
Lines 16 to 17 in 7cf80bb
but it returns
(gamma, beta, alpha)
as far as I see,s2fft/s2fft/sampling/so3_samples.py
Line 43 in 7cf80bb
which also seems to be consistent with the rest of the library. Is this a mistake in the documentation or did I misunderstand something?
Thanks in advance for the clarification!
The text was updated successfully, but these errors were encountered: