Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsr_driver with --xlines sometimes creates bad fits #42

Open
teuben opened this issue Feb 6, 2023 · 2 comments
Open

rsr_driver with --xlines sometimes creates bad fits #42

teuben opened this issue Feb 6, 2023 · 2 comments
Labels
Basically Done all but marked as done

Comments

@teuben
Copy link
Contributor

teuben commented Feb 6, 2023

Example of problem in 104790:

 SLpipeline.sh obsnum=104790 xlines=110.7,0.1     ok
 SLpipeline.sh obsnum=104790 xlines=110.7,0.15    bad
 SLpipeline.sh obsnum=104790 xlines=110.7,0.2     bad
 SLpipeline.sh obsnum=104790 xlines=110.7,0.25    bad
 SLpipeline.sh obsnum=104790 xlines=110.7,0.3     ok
 SLpipeline.sh obsnum=104790 xlines=110.7,0.4     ok

the driver version of the script will show large positive and/or negative components. the rsr_sum is ok, as it does not use the xlines concept. @dsancheza

@teuben
Copy link
Contributor Author

teuben commented Feb 7, 2023

it seems the logic is reversed when the window is blanked. It will try and use the xlines= section of the spectrum when that band was blanked (e.g. via badcb=), instead of not using it.

To clarify: the xlines= keyword in the pipline becomes a --exclude keyword for rsr_driver

@teuben teuben added the Basically Done all but marked as done label Mar 6, 2023
@teuben
Copy link
Contributor Author

teuben commented Mar 6, 2023

With the fix in rsr_driver and adjusting the threshold parameters as need be, this seems solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Basically Done all but marked as done
Projects
None yet
Development

No branches or pull requests

1 participant