Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty catalog view #657

Closed
3 tasks
xyntechx opened this issue Nov 14, 2023 · 3 comments
Closed
3 tasks

Empty catalog view #657

xyntechx opened this issue Nov 14, 2023 · 3 comments
Assignees

Comments

@xyntechx
Copy link
Contributor

Currently, the catalog just displays an empty view when no class has been selected. Instead, figure out a way to do the following:

  • Save recent searches to localStorage and display (this might take some extra consideration; I would suggest displaying the search and the semester but save all filters)
  • Display saved classes
  • Add an "X" button so the user can deselect any class they have selected and return to the empty view with recent searches, recent classes, etc.
@xyntechx xyntechx self-assigned this Nov 14, 2023
@xyntechx xyntechx converted this from a draft issue Nov 14, 2023
@xyntechx
Copy link
Contributor Author

xyntechx commented Nov 14, 2023

@mathhulk

Considerations:

  • Users can only save classes when logged in (when logged out, the bookmark icon to save classes doesn't even appear) -> this means that displaying saved classes is only for logged in users, hence I will do up TODO 1 for every user and TODO 2 for logged in users
  • To keep the design consistent, I think we should display recent and saved classes like the component below
  • Display 4 most recently viewed classes (header: Recently Viewed) + all saved classes (for logged in users; header: Saved)
Screenshot 2023-11-14 at 09 24 22

@Jdyn
Copy link
Contributor

Jdyn commented Nov 14, 2023

Hello what is the plan for this? Is this a duplicate of #624? I have work on this in progress already

@xyntechx
Copy link
Contributor Author

xyntechx commented Nov 14, 2023

@Jdyn oh icic. Matt and I just synced about this yesterday so I didn't know you were already working on it. @mathhulk should Jaden handle this task then?

@github-project-automation github-project-automation bot moved this from In Progress to Done in Berkeleytime Projects Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants