Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aiofiles locked dependency #11

Open
s0undt3ch opened this issue Dec 15, 2021 · 1 comment
Open

aiofiles locked dependency #11

s0undt3ch opened this issue Dec 15, 2021 · 1 comment

Comments

@s0undt3ch
Copy link

Why is aiologger locking the aiofiles dependency?
This a library, shouldn't it be using a constrain instead?
aiofiles>=0.4.0

Because now, any other project is forced to use aiofiles==0.4.0 or it can result in a broken dependency tree if a newer version of aiofiles is required by any other dependency...
@diogommartins
Copy link
Collaborator

Why is aiologger locking the aiofiles dependency? This a library, shouldn't it be using a constrain instead? aiofiles>=0.4.0

Because now, any other project is forced to use aiofiles==0.4.0 or it can result in a broken dependency tree if a newer version of aiofiles is required by any other dependency...

I'm ok with loosing up this dependency. Would you like to submit a PR, @s0undt3ch ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@s0undt3ch @diogommartins