-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add spec v3 support #160
base: master
Are you sure you want to change the base?
Conversation
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
@jonaslagoni @derberg here's a PR for spec v3 support in diff. It's a draft PR(right now there's no tests, and docs, etc). Please review the approach and the code changes I have made here. One question: As discussed in the meeting I had with Jonas, we aren't going to compare v2 against v3. I'm not sure what type of error do we show here? An early return? Keep in mind that this will be used by CLI, so we need to have it so that CLI is able to show the error as well. |
sorry for late response. so basically the diff tool purpose is to help people with review of changes that they are doing in their documents to identify breaking changes or new topics, or other things. So yeah, I think you should disallow comparing files between versions and throw error that it is technically not possible and why. Does that help? |
This pull request has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation. There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
@asyncapi/bounty_team |
Quality Gate failedFailed conditions |
Description
Add support for AsyncAPI v3
Related issue(s)
#154