Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add spec v3 support #160

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Conversation

aayushmau5
Copy link
Member

Description

Add support for AsyncAPI v3

Related issue(s)
#154

@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
78.1% 78.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@aayushmau5
Copy link
Member Author

@jonaslagoni @derberg here's a PR for spec v3 support in diff. It's a draft PR(right now there's no tests, and docs, etc). Please review the approach and the code changes I have made here.

One question:

As discussed in the meeting I had with Jonas, we aren't going to compare v2 against v3. I'm not sure what type of error do we show here? An early return? Keep in mind that this will be used by CLI, so we need to have it so that CLI is able to show the error as well.

@aayushmau5 aayushmau5 changed the title feat: inital version of spec v3 support feat: add spec v3 support Sep 7, 2023
@derberg
Copy link
Member

derberg commented Oct 11, 2023

sorry for late response.

so basically the diff tool purpose is to help people with review of changes that they are doing in their documents to identify breaking changes or new topics, or other things. So yeah, I think you should disallow comparing files between versions and throw error that it is technically not possible and why. Does that help?

Copy link

github-actions bot commented Feb 9, 2024

This pull request has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this pull request, add a comment with detailed explanation.

There can be many reasons why some specific pull request has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this pull request forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 9, 2024
@github-actions github-actions bot closed this Jun 8, 2024
@aayushmau5 aayushmau5 reopened this Oct 27, 2024
@asyncapi-bot asyncapi-bot added the bounty AsyncAPI Bounty label Nov 1, 2024
@aeworxet
Copy link

aeworxet commented Nov 1, 2024

@asyncapi/bounty_team

@aayushmau5 aayushmau5 removed the stale label Nov 3, 2024
@aeworxet aeworxet mentioned this pull request Nov 5, 2024
5 tasks
Copy link

sonarcloud bot commented Nov 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
75.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty AsyncAPI Bounty
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants